feat(standards): add fee::assert_fee_bound - #3797
Open
mmagician wants to merge 1 commit into
Open
Conversation
mmagician
force-pushed
the
mmagician-claude/port-fee-assert-bound
branch
2 times, most recently
from
September 3, 2026 12:59
ef30af6 to
65af8a5
Compare
mmagician
changed the title
fee::assert_fee_bound
mmagician
force-pushed
the
mmagician-claude/port-fee-assert-bound
branch
from
September 3, 2026 14:03
65af8a5 to
d0320e2
Compare
mmagician
force-pushed
the
mmagician-claude/port-fee-assert-bound
branch
from
September 3, 2026 14:23
d0320e2 to
9b4011f
Compare
Ports #3785 from release/v0.16.0-rc to next. Adaptations for next: - pin the payment to the native fee asset by comparing asset IDs via `tx::get_fee_asset_id` (`tx::get_fee_faucet_id` no longer exists); the error constant is renamed to `ERR_FEE_PAYMENT_ASSET_NOT_NATIVE` - the bound test helper builds the transaction and the tests own execution Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KkQzFtRjyDwQ7iVtRbsHsn
mmagician
force-pushed
the
mmagician-claude/port-fee-assert-bound
branch
2 times, most recently
from
September 3, 2026 15:06
9b4011f to
6eb78c3
Compare
zeapoz
approved these changes
Sep 4, 2026
Comment on lines
+305
to
+306
| # the bound holds iff payment_amount * bound_den <= fee_amount * bound_num; both sides are | ||
| # computed as 128-bit products, so the comparison is exact and cannot overflow |
Collaborator
There was a problem hiding this comment.
Suggested change
| # the bound holds iff payment_amount * bound_den <= fee_amount * bound_num; both sides are | |
| # computed as 128-bit products, so the comparison is exact and cannot overflow | |
| # the bound holds iff payment_amount * bound_den <= fee_amount * bound_num; both sides are | |
| # split into 32-bit limbs and computed as 128-bit products, so the comparison is exact and | |
| # cannot overflow |
nit: I think we could explicitly mention the splitting step too to be more precise
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports #3785 to
next.fee::assert_fee_boundlets a caller cap what a transaction may pay before paying it: the payment must be in the native fee asset and at mostnum / dentimes the computed fee.